feat: sqlite cache store #3657
Open
feat: sqlite cache store #3657
+687
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flakey5
force-pushed
the
flakey5/20240910/sqlite-cache-store
branch
from
c33c78e
to
6c8ea8f
Compare
flakey5
force-pushed
the
flakey5/20240910/sqlite-cache-store
branch
from
6c8ea8f
to
a015bf2
Compare
flakey5
commented
Oct 15, 2024
SukkaW
reviewed
Oct 15, 2024
flakey5
force-pushed
the
flakey5/20240910/sqlite-cache-store
branch
2 times, most recently
from
592ffb3
to
d951470
Compare
mcollina
requested changes
Oct 16, 2024
mcollina
reviewed
Oct 25, 2024
flakey5
force-pushed
the
flakey5/20240910/sqlite-cache-store
branch
from
19b0eaf
to
93a306c
Compare
flakey5
force-pushed
the
flakey5/20240910/sqlite-cache-store
branch
2 times, most recently
from
34b34d7
to
60a9679
Compare
Co-authored-by: Robert Nagy <[email protected]> Co-authored-by: Isak Törnros <[email protected]> Signed-off-by: flakey5 <[email protected]>
flakey5
force-pushed
the
flakey5/20240910/sqlite-cache-store
branch
from
60a9679
to
8e0fa89
Compare
mcollina
reviewed
Nov 14, 2024
Signed-off-by: flakey5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is a draft since #3562 isn't landed. Until it is landed, this will be based off of that pr's branch. For the actual diff see flakey5/undici@flakey5/3231...flakey5:undici:flakey5/20240910/sqlite-cache-storeThis relates to...
Adding client side http caching (#3562)
Rationale
Adds a sqlite cache store option given the
--experimental-sqliteflag is providedChanges
Features
Bug Fixes
n/a
Breaking Changes and Deprecations
n/a
Status
cc @mcollina @ronag